search

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing
Other
156 stars 45 forks source link

update to ns3 v3.40, Ubuntu 22.04 and Go 1.21.5 #110

Closed larseggert closed 10 months ago

marten-seemann commented 11 months ago

Looks like we have two PRs now that do the same thing: #113 and this one. Which one should we take?

marten-seemann commented 11 months ago

I fixed CI in #114. Can you rebase please?

larseggert commented 10 months ago

@marten-seemann done

marten-seemann commented 10 months ago

@larseggert Thank you! Do you have any thoughts regarding this PR vs #113?

larseggert commented 10 months ago

113 seems to be similar, but also includes a bunch of other things (let "generated executable filenames be created without ns3 version numbers"). I'm obviously biased, but mine is shorter :-) Maybe ask the author of #113 if they think anything is missing in mine?

jaikiran commented 10 months ago

Hello Lars, Marten, please go ahead with this current PR. I see that this one also upgrades ubuntu and Go version to a higher version than what my PR does.

As for the changes to the ns3 build itself, in my PR, I introduced a complete new build file (CMakeLists.txt) to build the quic interop scenarios and that build file would be part of this repo. I see that Lars patches the ns3 build system files to build the quic interop scenarios (which is what was anyway being done so far). I don't have any specific preference and since the changes in this current PR appear to be functional, I think it's better to go ahead with this current PR.

I do plan to apply the changes in this PR locally and build the simulator container and run the quic interop tests. I will get to it in a few days, but integrating this PR doesn't have to wait for it - I can open a new issue/PR if I run into any issues with this change. Thank you for these upgrades.

marten-seemann commented 10 months ago

Thank you @jaikiran and @larseggert!