search

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing
Other
145 stars 44 forks source link

Bug in run.sh caused from latest merged commit pr #110 #121

Closed KolbyML closed 6 months ago

KolbyML commented 6 months ago

I found a bug introduced with #110

{"log":"./run.sh: line 25: ./scratch/droplist: No such file or directory\r\n","stream":"stdout","time":"2024-01-08T23:06:00.950207463Z"}

I am currently am trying to debug this as this is breaking our CI, but I thought I would post this issue just so people know the problem is out there.

We are using the sim for context

KolbyML commented 6 months ago

It looks like the issue is with the new patch file sim/CMakeLists.patch or something and the scratch folder is never created

KolbyML commented 6 months ago

Ok I debugged it a bit I all the files now for some reason include a prefix ns3-<version> this was causing that original error after I resolved that problem I got this error

sim  | Using scenario: droplist --delay=15ms --bandwidth=10Mbps --queue=25 --drops_to_server=3,5,7 --drops_to_client=6,8
sim  | msg="EmuFdNetDeviceHelper::CreateFileDescriptor(): Back from execlp(), status = -1, errno = No such file or directory", +0.000000000s -1 file=/ns3/src/fd-net-device/helper/emu-fd-net-device-helper.cc, line=316
sim  | NS_FATAL, terminating
sim  | terminate called without an active exception
sim  | msg="EmuFdNetDeviceHelper::CreateFileDescriptor(): socket creator exited abnormally", +0.000000000s -1 file=/ns3/src/fd-net-device/helper/emu-fd-net-device-helper.cc, line=352
sim  | NS_FATAL, terminating
sim  | terminate called without an active exception
sim  | ./run.sh: line 31:    13 Aborted                 (core dumped) ./scratch/droplist --delay=15ms --bandwidth=10Mbps --queue=25 --drops_to_server=3,5,7 --drops_to_client=6,8
sim exited with code 0

I believe it is due to emu-fd-net-device-helper.o not being included in the final docker image anymore but I am not 100% sure.

I tested the alternative PR https://github.com/quic-interop/quic-network-simulator/pull/113 to update ns3 to 3.40 and it worked so I think we should revert the one which one was merged and merge that pr which did work.

I believe going forward we should add a small ci which runs a basic configuration to see if it will work, to prevent mishaps like this in the future.

marten-seemann commented 6 months ago

@larseggert Looks like #110 is causing some problems. Could you take a look please?