search

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing
Other
145 stars 44 forks source link

revert PR #100 and replace it with #113 to fix crash on sim initialization #122

Closed KolbyML closed 6 months ago

KolbyML commented 6 months ago

This is a possible resolution of https://github.com/quic-interop/quic-network-simulator/issues/121

I tested #113 and it did work.

If the author of #110 does want to make a fix that is cool and we can close this. If not this PR will resolve the issue.

This is a very cool project :+1:, but it could really use a simple CI to prevent an issue like this happening again

marten-seemann commented 6 months ago

Let's see if the author of #110 can fix this quickly. If we revert, I'd just go back to the old ns-3 version for now.

This is a very cool project 👍, but it could really use a simple CI to prevent an issue like this happening again

Any suggestion how to test this on CI? Want to contribute a test?

KolbyML commented 6 months ago

That is fine I will close this then. I can make an very basic one which would have prevented this assuming I can get some time sure