search

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing
Other
145 stars 44 forks source link

ci: add ci to prevent future pr's breaking sim #124

Open KolbyML opened 6 months ago

KolbyML commented 6 months ago

@marten-seemann ok the PR is ready for review. I tested it on master and it failed as expected. I also tested it with the Fix Lars summited and the test passed as expected.

The test is very minimal in scope, but it prevents the event that happened yesterday so it does its job.

Cheers!

KolbyML commented 6 months ago

@marten-seemann it only takes image 7-8 minutes. I am not sure what you are referring to when you say (~1h) on CI

Also yeah for sure that is no issue!

marten-seemann commented 6 months ago

Huh, this is weird. What's going on here? Compiling ns3 from scratch takes more than an hour, see https://github.com/quic-interop/quic-network-simulator/actions/runs/7465935034/job/20328138279?pr=124

KolbyML commented 6 months ago

Maybe that is being caused by qemu? I did docker build -f sim/Dockerfile . and it was always taking less then 7 minutes on ci I was testing it all morning

KolbyML commented 6 months ago

In that case I don't think we should combine the CI

I am going to rebase the pr to show it becomes green with Lars fix

KolbyML commented 6 months ago

Here is a picture taken on broken master for future reference image

KolbyML commented 6 months ago

@marten-seemann you have to approve the CI to run. But anyways it will be successful and run in 7-8 minutes which is not 90 minutes so I don't think we should merge the 2 CI's together. QEMU do be slow though