search

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing
Other
151 stars 45 forks source link

Bump ubuntu base image in endpoint image #125

Closed tatsuhiro-t closed 2 months ago

tatsuhiro-t commented 6 months ago

simulator image got a upgrade to use ubuntu 22.04, but endpoint image is still 20.04. Is there any chance to upgrade the base image of endpoint Dockerfile to 22.04 as well?

marten-seemann commented 6 months ago

I hope this would be fine, but I'm wondering if we'd be breaking people's builds.

tatsuhiro-t commented 6 months ago

I built ngtcp2 interop image with custom entrypoint image as ubuntu 22.04 base, and all interop tests succeeded except for A which has a known issue (see https://github.com/quic-interop/quic-interop-runner/pull/376).

but I'm wondering if we'd be breaking people's builds.

We can change the image name or tag, like:

etc

and tell people that old image will not get any update, and they should migrate their image to use new image. What do you think about this?

marten-seemann commented 2 months ago

I think we should do it, and see if it actually breaks builds. If it does, we can just apply a Docker tag to the old image, to give people time to update their implemenations.