Add logging and fix a couple of issues

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing

Other

152 stars 45 forks source link

Add logging and fix a couple of issues #28

Closed janaiyengar closed 5 years ago

janaiyengar commented 5 years ago

Run with python, to get log access: python3 run.py -l DEBUG. I would remove run.sh entirely.

There're a couple of important changes:

I see a different output from docker-compose on exit. Check if this is the same for you.
```
- return any("exit status 127" in str(l) for l in lines)
+ return any("exited with code 127" in str(l) for l in lines)
```
- I don't think we should overload $CLIENT_PARAMS. I've added $REQUESTS for use in interop.

marten-seemann commented 5 years ago

The difference in the output is probably due to different Docker or docker-compose versions. That's why we need to dockerize the interop runner at some point...

I'm currently running:

❯ docker -v
Docker version 19.03.2, build 6a30dfc
❯ docker-compose -v
docker-compose version 1.24.1, build 4667896b

janaiyengar commented 5 years ago

> docker-compose -v
docker-compose version 1.24.1, build 4667896b
> docker -v
Docker version 19.03.2, build 6a30dfc

We've got the same exact builds. I'm running this on a Mac, what are you running it on?