allow flags to be defined multiple times

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing

Other

147 stars 44 forks source link

allow flags to be defined multiple times #43

Closed marten-seemann closed 4 years ago

janaiyengar commented 4 years ago

Also, how about --substitute (-b), instead of --replace?

marten-seemann commented 4 years ago

Actually, I quite like the comma-separated list for client and server, to be honest. I think it's a lot more readable once we have a few implementations there. Let's not remove that one.

janaiyengar commented 4 years ago

Yeah, I was ambivalent about those. I agree that it might be better as is. Can you make those changes?

marten-seemann commented 4 years ago

Closing this PR. Maybe what we currently have is not too bad for now.