quic / ai-hub-models

The Qualcomm® AI Hub Models are a collection of state-of-the-art machine learning models optimized for performance (latency, memory etc.) and ready to deploy on Qualcomm® devices.
https://aihub.qualcomm.com
BSD 3-Clause "New" or "Revised" License
338 stars 45 forks source link

Add QuIC Repolinter check #39

Closed quic-nwtn closed 1 month ago

quic-nwtn commented 1 month ago

This GitHub Action runs Repoliner on push or pull requests to master. This should've been enabled when the project was first setup. We need to enable this and correct violations (ignore the Warnings and focus on the Errors). In some cases, the repolinter rules need to be tweaked depending on the project, which we can discuss.

kory commented 1 month ago

@quic-nwtn , this checks from the Repolinter are already checked by our existing PR checks. Do we really need this additional linter file?

quic-nwtn commented 1 month ago

@mynameistechno , please help here.

mynameistechno commented 1 month ago

@quic-nwtn , this checks from the Repolinter are already checked by our existing PR checks. Do we really need this additional linter file?

This runs as pre commit hooks?

kory commented 1 month ago

Yes. Currently we are not set up to merge public commits. When public PRs are submitted, they are merged elsewhere with the appropriate PR checks and included in the following release.