search

quic / aimet-model-zoo

Other
296 stars 53 forks source link

fix the encoding.csv file lacation to the right diractory #38

Closed aiwhz closed 1 year ago

aiwhz commented 1 year ago

The path of the encoding.csv now uses a relative path, which is not correct, and cannot find the downloaded encoding.csv. We can use the self.model_name_or_path, which is initialized with the right absolute path correctly.

FelixSchwarz commented 1 year ago

@aiwhz This looks like an obvious fix to me but I think you need to add the "Signed-Off-By" tag to your commit. For details you can check out the "Details" link in this PR. And as you have to force-push anyway maybe you can also fix the spelling errors in your commit description ("lacation", "diractory").

quic-hanwxion commented 1 year ago

This is done in another PR: https://github.com/quic/aimet-model-zoo/pull/45