Closed corneliusboehm closed 3 years ago
Ready for a final review, so we can merge what we have so far.
These questions are still open and can be addressed later:
--backbone_version
--backbone_variant
instead to avoid confusion with a numerical version? Or merge version into --backbone_name
, so that users only have to indicate one?--model_name
and --model_version
, while the tools call it --backbone_name
. Should we unify those?SIEN/SI-EN
and SIMN/SI-MN
?I haven't finished reviewing yet... but regarding your questions:
Call --backbone_version --backbone_variant instead to avoid confusion with a numerical version? Or merge version into --backbone_name, so that users only have to indicate one?
No strong opinion here. I'm fine with all 3 solutions (leave it like this, rename to "backbone_variant" or merge into "backbone_name"). I suggest we leave it like this in this PR and change that in another PR if anyone has a strong opinion about this and wants to do it.
In the example scripts, the command line parameters are called --model_name and --model_version, while the tools call it --backbone_name. Should we unify those?
Yes, I think that would be good.
Should we shorten all model names to SIEN/SI-EN and SIMN/SI-MN?
I vote "yes".
"Fine-tune" instead of "finetune"?
No strong opinion
Description
Support using different model versions in all
tools
.General Changes
tools/utils.py
get_weights
was moved into theModelConfig
class so that it's also possible to obtain the weights for a specific model configSenseStudio
Training
model_name
andmodel_version
. If those are not provided, the best available model will automatically be used.config.json
file. This can later for example be used to look up the correct backbone model.Running custom classifier
config.json
fileConversion
backbone_name
andbackbone_version
for pre-trained classifiers orpath_in
for a custom classifier