search

quick-lint / quick-lint-js

quick-lint-js finds bugs in JavaScript programs
https://quick-lint-js.com
GNU General Public License v3.0
1.54k stars 192 forks source link

Feature/warn missing fallthrough #1094

Closed yashmasani closed 11 months ago

yashmasani commented 1 year ago

Add and report a diagnostic for missing fallthrough within switch statements. Fixes #1081

strager commented 1 year ago

Thanks for the pull request. I think you're on the right track. There are a lot of things to consider, though, which is one reason I didn't mark the task as for-hire or good-first-issue.

yashmasani commented 12 months ago

Thanks for the pull request. I think you're on the right track. There are a lot of things to consider, though, which is one reason I didn't mark the task as for-hire or good-first-issue.

Thank you for the review. All comments were very clear and concise so I could make the changes easily.

strager commented 11 months ago

If you want, I can fix the remaining issues. Let me know.

yashmasani commented 11 months ago

If you want, I can fix the remaining issues. Let me know.

I addressed the remaining issues. Thanks!

strager commented 11 months ago

Landed as commit 422f3b46349c3de3e5fb737fd48556c352498c3c. :+1: