search

quick-lint / quick-lint-js

quick-lint-js finds bugs in JavaScript programs
https://quick-lint-js.com
GNU General Public License v3.0
1.52k stars 192 forks source link

27$: LSP: Don't crash on missing fields, unknown methods, and invalid JSON #111

Closed strager closed 2 years ago

strager commented 3 years ago

Crashes bit @tiagovla when he was implementing #105.

strager commented 3 years ago

I've been doing this work but for the config file parser. simdjson makes it difficult to deal with invalid JSON. For example, I don't know how to work around this simdjson crash: https://github.com/simdjson/simdjson/issues/1661

If we can't fix the simdjson bugs, then we'll need to switch to a different JSON parser (or use two: one for validation and one for parsing).

strager commented 2 years ago

Most issues are fixed now. There are still some crashes, but they're unlikely to happen with decently-written clients.