Closed strager closed 6 months ago
Anything related to the following syntax is a namespace alias (despite the fact that the keyword import
is used):
import ns = otherns;
Anything related to the following syntax is an import alias (thus shouldn't be renamed):
import m = require('mod');
(I forgot about the second case when I filed this issue.)
This task would involve going through each instance of import_alias
or import alias
in the code, figuring out whether it's an import alias or a namespace alias, and renaming when it's a namespace aliases.
@strager close this?
@cmstoddard No, this issue is still present.
Hello, I have a few questions:
I found some files in test folder, which has some function name like ...import_alias... but verifies namespace alias, does it mean to change function name to ...namespace_alias...?
Yes.
In both cases import alias and namespace alias you mentioned, the same error message display (TypeScript import aliases are not allowed in JavaScript- E0274), do we also need to have a new message to match with namespace alias case?
I wasn't thinking about this, but it'd be nice to have different messages for the different cases, yes.
Does this mean anything named with import_alias should be renamed to namespace_alias?