search

quick-lint / quick-lint-js

quick-lint-js finds bugs in JavaScript programs
https://quick-lint-js.com
GNU General Public License v3.0
1.52k stars 191 forks source link

refactor(util): use parse_integer from simdjson #1202

Closed msharipov closed 6 months ago

msharipov commented 6 months ago

simdjson provides functions for parsing decimal integers that should run faster than manually coded equivalent. Changed parse_integer_exact to use the parse_integer function from simdjson. Due to inconsistencies between what simdjson and the original implementation consider to be an error, some pre-emptive checks are run on the input string to avoid false positives/negatives. closes #915

github-actions[bot] commented 6 months ago

CLA Assistant Lite bot Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution.

EDIT: All contributors have signed quick-lint-js' Contributor License Agreement (CLA-v1.md).

msharipov commented 6 months ago

I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md).

msharipov commented 6 months ago

recheck

strager commented 6 months ago

As I wrote in the GitHub issue (#915), I don't think reusing simdjson makes sense for us. I am therefore won't merge your changes and am closing this pull request.