Closed CoderMuffin closed 5 months ago
CLA Assistant Lite bot Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution.
EDIT: All contributors have signed quick-lint-js' Contributor License Agreement (CLA-v1.md).
I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md)
recheck
Great! I will apply the suggested changes and fix the formatting tonight :)
I think that should be everything fixed! Not sure if it will pass the formatting check - it should do, but I am using clang-format 11 on my system. If you are ok with it then I am happy for you to merge :)
One other question I had - do I need to do something else to accept the CLA seems to fail every time? (edit - I think I am missing a .)
I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md).
Thanks for the patch! Landed as Git commit d09a1a72675fd1673dac5793b099c6169698829d.
@strager Great thanks! Unfortunately I did not include the correct keywords in the initial PR, so the original issue (#1207) is still open (just in case you wanted to close/delete it)
Initial draft for fix of #1207 unfortunately the commit history is a bit of a mess fixes #1207