search

quick-perf / quickperf

QuickPerf is a testing library for Java to quickly evaluate and improve some performance-related properties
https://github.com/quick-perf/doc/wiki/QuickPerf
Apache License 2.0
488 stars 65 forks source link

Improve SQL annotation issue due to the framework debugging #104

Closed loicmathieu closed 4 years ago

loicmathieu commented 4 years ago

Description Improve SQL annotation issue due to the framework debugging by generating a specific exception when no query has been intercepted.

Implementation ideas

  1. When one of the SQL annotation is used but no query has been intercepted, throw a specific exception with possible causes. This is specifically important for annotation like @ExpectMax[...] as it will validate no queries.
  2. Provide @ExceptNoSQLQuery annotation for a user to specifically check for no queries.
  3. Provide "framework hints": 3.1 Add the capabulity to detect known framework at runtime: SpringBoot, Micornaut, Quarkus 3.2. Hint of what could possibly be wrong and link to the documentation site (or the example repository).

The point 3 can be provided later.

loicmathieu commented 4 years ago

@jeanbisutti I saw you assign it to yourself, I can take care of this one if you want.

jeanbisutti commented 4 years ago

@jeanbisutti I saw you assign it to yourself, I can take care of this one if you want.

@loicmathieu Thank you for your proposal. I have implemented a large part. I try to finish this week.

jeanbisutti commented 4 years ago

Implemented