search

quick-perf / quickperf

QuickPerf is a testing library for Java to quickly evaluate and improve some performance-related properties
https://github.com/quick-perf/doc/wiki/QuickPerf
Apache License 2.0
469 stars 67 forks source link

:white_check_mark: add unit tests and methods for SQL statements with… #125

Closed MohamedKaraga closed 3 years ago

MohamedKaraga commented 3 years ago

… IN,BETWEEN,LIKE,NESTED,UPDATE and refactor

jeanbisutti commented 3 years ago

@MohamedKaraga, many thanks for this PR and the time you spent working on this.

There is a build issue with the changes. You can view the build state from the PR:

image

The issue is that you add a Java 1.9 compiler in sql-annotations module. However, this module has to be compiled in Java 1.7. The reason is that we want QuickPerf to be able to improve the performances of legacy applications. QuickPerf 2.0 will use Java 1.8 for SQL annotations. The Maven Enforcer plugin checks 1.7 compilation.

Could you please update this PR to compile the sql-annotations module with 1.7?

jeanbisutti commented 3 years ago

Replaced by #129