quick-perf / quickperf

QuickPerf is a testing library for Java to quickly evaluate and improve some performance-related properties
https://github.com/quick-perf/doc/wiki/QuickPerf
Apache License 2.0
489 stars 65 forks source link

Unable to disable QuickPerf on a test method #131

Closed gmarziou closed 4 years ago

gmarziou commented 4 years ago

Hello,

Using QuickPerf 1.0, JUnit 5, Spring Boot 2.3.

I have a repository test class that is annotated with @QuickPerfTest but it contains few @ParameterizedTest annotated methods that are not supported so I tried to disable them by annotating them with @DisableQuickPerf but it does not work: they are still in error

@SpringBootTest(classes = ServeurIsoleApp.class, webEnvironment = NONE)
@Import(QuickPerfSqlConfig.class)
@QuickPerfTest
class TapRepositoryIT {

    @ParameterizedTest
    @EnumSource(EtatTap.class)
    @DisableQuickPerf
    void enregistrement_avec_tous_les_etats(EtatTap etat) {
jeanbisutti commented 4 years ago

@ParameterizedTest uses JUnit 5 test template (JUnit 5 code). QuickPerf 1.0.0. does not support JUnit 5 test template. There is the #114 PR to support it. :) I am going to review it. After the merging of this PR, I could deploy a snapshot version of QuickPerf. I could then propose you to check that everything is fine now in your tests with the snapshot version.

gmarziou commented 4 years ago

Thanks @jeanbisutti this would be great but you don't need to deploy a snapshot version, I can build it locally and test it.

jeanbisutti commented 4 years ago

Hello @gmarziou, for information, I reviewed #114 PR

jeanbisutti commented 4 years ago

Hello @gmarziou, #114 was merged.

If you have time, it would be nice to check that everything is now fine in your tests with QuickPerf master.

gmarziou commented 4 years ago

It works fine! Thanks to both @jeanbisutti and @loicmathieu