search

quick-perf / quickperf

QuickPerf is a testing library for Java to quickly evaluate and improve some performance-related properties
https://github.com/quick-perf/doc/wiki/QuickPerf
Apache License 2.0
489 stars 65 forks source link

GC declaration issue #159

Closed FranckDemeyer closed 3 years ago

FranckDemeyer commented 3 years ago

Describe the bug Hi, I think there's a little mistake made in GC enum class : When declaring SHENANDOAH the flag used in JvmOption is set tonew JvmOption("-XX:+UseZGC")

Expected behavior I think the flag should be set to new JvmOption("-XX:+UseShenandoahGC")

Look directly at : quickperf/jvm/jvm-annotations/src/main/java/org/quickperf/jvm/gc/GC.java

Versions

jeanbisutti commented 3 years ago

Hi @FranckDemeyer,

Indeed, there is a mistake!

Thank you very much for taking the time to look at the QuickPerf code and noticing the mistake!

Would you be interested in providing a fix?

FranckDemeyer commented 3 years ago

Hi @jeanbisutti, I'll send a PR as soon as I can. 😊

jeanbisutti commented 3 years ago

I'll send a PR as soon as I can. 😊

Great @FranckDemeyer! When you could!

FranckDemeyer commented 3 years ago

@jeanbisutti : https://github.com/quick-perf/quickperf/pull/161

jeanbisutti commented 3 years ago

Fixed with 59dee49c1082d918e28c0312b80fd92eb6b01bd4. Thank you @FranckDemeyer!