quick-perf / quickperf

QuickPerf is a testing library for Java to quickly evaluate and improve some performance-related properties
https://github.com/quick-perf/doc/wiki/QuickPerf
Apache License 2.0
465 stars 67 forks source link

Add TestNG SQL Listener #175

Closed oliver-hughes closed 2 years ago

oliver-hughes commented 2 years ago

44 TestNG & Spring

Add QuickPerf SQL TestNG Listener. Listener can be added as described here Example usage shown here.

jeanbisutti commented 2 years ago

Many thanks for this PR.

I have allowed the CI, as it's your first PR on QuickPerf.

The builds have failed:

/home/runner/work/quickperf/quickperf/testng/testng-sql-listener/src/test/java/org/quickperf/testng/sql/QuickPerfSqlTestNGListenerTest.java:[3,28] cannot find symbol
  symbol:   class TestNGTests
  location: package org.quickperf.testng
Error:  /home/runner/work/quickperf/quickperf/testng/testng-sql-listener/src/test/java/org/quickperf/testng/sql/QuickPerfSqlTestNGListenerTest.java:[15,9] cannot find symbol
  symbol:   class TestNGTests
  location: class org.quickperf.testng.sql.QuickPerfSqlTestNGListenerTest
Error:  /home/runner/work/quickperf/quickperf/testng/testng-sql-listener/src/test/java/org/quickperf/testng/sql/QuickPerfSqlTestNGListenerTest.java:[15,35] cannot find symbol
  symbol:   variable TestNGTests
  location: class org.quickperf.testng.sql.QuickPerfSqlTestNGListenerTest
Error:  /home/runner/work/quickperf/quickperf/testng/testng-sql-listener/src/test/java/org/quickperf/testng/sql/QuickPerfSqlTestNGListenerTest.java:[18,20] package TestNGTests does not exist

Adding this dependency to the new Maven module should fix the issue:

        <dependency>
            <groupId>org.quickperf</groupId>
            <artifactId>quick-perf-testng-test-util</artifactId>
            <version>1.1.1-SNAPSHOT</version>
            <classifier>tests</classifier>
            <type>test-jar</type>
            <scope>test</scope>
        </dependency>

Could you also please add a license header to each new file?

Thank you.

jeanbisutti commented 2 years ago

Great! Thank you!

Close #44