Make @ProfileJvm display the young GC count #71

quick-perf / quickperf

QuickPerf is a testing library for Java to quickly evaluate and improve some performance-related properties

https://github.com/quick-perf/doc/wiki/QuickPerf

Apache License 2.0

488 stars 65 forks source link

Make @ProfileJvm display the young GC count #71 #76

Closed ubaid4j closed 4 years ago

ubaid4j commented 4 years ago

add display the number of young collections.

a private method getYoungGcCount(IItemCollection jfrEvents) add in DisplayJvmProfilingValueVerifier class
display Young: (number of collections) below Longest GC pause

ubaid4j commented 4 years ago

Should I close the pull request now?

jeanbisutti commented 4 years ago

Thanks for this contribution @UbaidurRehman1!

The PR content is ok for me. I would like to merge this PR on master together with #70.

Are you always intereted in working on #70?

ubaid4j commented 4 years ago

Yup I am interested. Assign me #70.

jeanbisutti commented 4 years ago

Should I close the pull request now?

@UbaidurRehman1 It's ok to keep this PR for the second issue

ubaid4j commented 4 years ago

Should I close the pull request now?

@UbaidurRehman1 It's ok to keep this PR for the second issue

Alright

jeanbisutti commented 4 years ago

@UbaidurRehman1 Could you please rebase on master, solve the conflict and after that squash the commit into one with a commit title "Make @ProfileJvm display the young GC count" ?

The other solution would be to open a new PR.

ubaid4j commented 4 years ago

@jeanbisutti conflict resolved.

jeanbisutti commented 4 years ago

Thanks @UbaidurRehman1. There are many commits (11). One would be perfect. The most simple would be to reclone and apply the changes for this issue I think. Thanks a lot for your contributions and the time you spent to work on QuickPerf.

ubaid4j commented 4 years ago

Thanks @UbaidurRehman1. There are many commits (11). One would be perfect. The most simple would be to reclone and apply the changes for this issue I think. Thanks a lot for your contributions and the time you spent to work on QuickPerf.

So, You want open a new PR?

ubaid4j commented 4 years ago

Thanks @UbaidurRehman1. There are many commits (11). One would be perfect. The most simple would be to reclone and apply the changes for this issue I think. Thanks a lot for your contributions and the time you spent to work on QuickPerf.

Squash is not done cause of their are your commits as well. So, the only option is to re-produce PR for this issue.

jeanbisutti commented 4 years ago

@UbaidurRehman1

So, You want open a new PR?

Yes, please. The commit history will be cleaner.

Thanks a lot for the time you are spending to work on QuickPerf.

jeanbisutti commented 4 years ago

Duplicated with #81