quickdesh / Animiru

Android video player
https://aniyomi.org/forks/Animiru/
Apache License 2.0
531 stars 12 forks source link

[F-R] Use Device Brightness When Disable Player Swipe Gestures #23

Open RickyM7 opened 1 year ago

RickyM7 commented 1 year ago

Describe your suggested feature

Maybe a option to choose your favorite behavior should be nice.

Other details

I think this should be the default behavior when disabling gestures.

Acknowledgements

quickdesh commented 1 year ago

should be fixed in next release

quickdesh commented 1 year ago

Option has been added in player settings

RickyM7 commented 1 year ago

The behavior of this feature is a bit strange, as the ideal would be to change the brightness of the phone and the player at the same time, but at the moment it is necessary to exit and return to playback for the brightness to be updated.

Animiru version: v0.14.1.4

quickdesh commented 1 year ago

Could you take a video and upload it here? I am a little confused as to what you mean

RickyM7 commented 1 year ago

Could you take a video and upload it here? I am a little confused as to what you mean

Unfortunately I can't record it, but you can reproduce it on your device with these steps:

  1. Play an episode of an anime
  2. Increase/decrease brightness via phone bar
  3. You will see that the playback brightness has not changed, so exit and enter playback and you will see that the brightness has now changed. Note: The option to remember the last brightness must be disabled, of course.
warior456 commented 1 year ago

This is also in the main app, for me my brightness bar is still locked when those options are toggled

killerlearner commented 11 months ago

Yeah it isn't using system brightness when brightness gesture is disabled and also last brightness gesture