search

quickemu-project / quickemu

Quickly create and run optimised Windows, macOS and Linux virtual machines
MIT License
9.91k stars 438 forks source link

fix: assign QEMU_IMG #1230

Closed philclifford closed 2 months ago

philclifford commented 2 months ago

Only used for macOS closes #1229

flexiondotorg commented 2 months ago

This is fixed via https://github.com/quickemu-project/quickemu/commit/8db310035541fd6b0fe17f388aaec914cb20da08 in a feature branch I am working on.

philclifford commented 2 months ago

That commit (or one like it) introduced the problem I think. Is there one that assigns to QEMU-IMG that can be cherry-picked into main ? The fix was actually in b7b759e7f14d8c3d11b59a9e11752eb9ac93aae9

flexiondotorg commented 2 months ago

@philclifford I reference the wrong commit, sorry. Here is the code now in quickget in my macos-host feature branch: https://github.com/quickemu-project/quickemu/blob/macos-host/quickget#L3395

QEMU_IMG=$(command -v qemu-img)
if [ ! -x "${QEMU_IMG}" ]; then
    echo "ERROR! qemu-img not found. Please make sure qemu-img is installed."
    exit 1
fi