quickemu-project / quickgui

An elegant virtual machine manager for the desktop

MIT License

993 stars 78 forks source link

fix: localizations #177

Closed ymauray closed 4 months ago

ymauray commented 4 months ago

Description

A whitespace has been added to a localizable message in the code, but the .po files have not been updated.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have performed a self-review of my code
[x] I have tested my code in common scenarios and confirmed there are no regressions

flexiondotorg commented 4 months ago

What do you run to update the .po files? I can investigate putting something in CI to get them up to date :slightly_smiling_face:

ymauray commented 4 months ago

There is no automated process for that. And I have no clue how to put one in place. The best course of action is to not touch the text in "context.t("Blah")", as this is the key that is used to fetch the messages in the .po files. It might be worth investigating how to look at the code for calls to context.t Maybe a code generator?

flexiondotorg commented 4 months ago

So how did all those .po files get updated exactly?

ymauray commented 4 months ago

I updated them all by hand.

ymauray commented 4 months ago

I think in debug mode, an exception should be thrown if a message is not found in the current language file (probably english, or french). Therefore, the developper would have to add the message at least one .po file, and hopefully, think about adding it to quickgui.pot

ymauray commented 4 months ago

By the way, currently, when a message is not found, it is displayed in the console.