quickfix-j / quickfixj

QuickFIX/J is a full featured messaging engine for the FIX protocol. - This is the official project repository.
http://www.quickfixj.org
Other
955 stars 611 forks source link

A test is needed to defend QuickFIXJ compatibility with FIX Dictionary Files generated from FIX Orchestra #336

Closed david-gibbs-ig closed 2 months ago

david-gibbs-ig commented 3 years ago

The FIX Orchestra project includes a utility to generate QFJ compatible dictionaries from an Orchestra Repo https://github.com/FIXTradingCommunity/fix-orchestra

The Orchestra model and the QuickFIX model are inconsistent in the way that they deal with Components and Groups. QuickFIX does not normalise Groups, Groups are defined in situ within the containing component. There are a small number of cases where Groups are required. To represent this without requiring that the Component and Group be defined in situ in the message the Group must be defined as required within the Component. e.g. <group name="NoPartyIDs" required="Y"> There are cases such as Component "Parties" where the component is not always required. QuickFIXJ validation does behave correctly in this case:

Providing a test case will guard against possible regressions that would introduce incompatibility between FIX Orchestra tooling and QuickFIXJ.

Please see also 👍 https://github.com/FIXTradingCommunity/fix-orchestra/issues/104

chrjohn commented 2 months ago

Obsolete, see https://github.com/quickfix-j/quickfixj/pull/337#issuecomment-1561079912

david-gibbs-ig commented 2 months ago

Agreed

From: Christoph John @.> Sent: Thursday, July 4, 2024 4:18 PM To: quickfix-j/quickfixj @.> Cc: David Gibbs @.>; Author @.> Subject: Re: [quickfix-j/quickfixj] A test is needed to defend QuickFIXJ compatibility with FIX Dictionary Files generated from FIX Orchestra (#336)

[EXTERNAL] This message originated outside of NADEX.

Obsolete, see #337 (comment)https://github.com/quickfix-j/quickfixj/pull/337#issuecomment-1561079912

- Reply to this email directly, view it on GitHubhttps://github.com/quickfix-j/quickfixj/issues/336#issuecomment-2209216107, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHCIBNTH3ABJ5ESIGI35WA3ZKVRRTAVCNFSM6AAAAABKLX222SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZGIYTMMJQG4. You are receiving this because you authored the thread.Message ID: @.***>


This electronic mail message and any attachments may contain confidential and/or privileged information that is only intended for use by, North American Derivatives Exchange, Inc. ("Nadex") or third-parties to whom it is directed. The contents of this electronic mail message are not to be copied, modified, published, transmitted, distributed, performed, displayed, or sold in any way. If you are not the addressee, you are prohibited from disclosing, copying, distributing or taking any action based on the contents of this message. If you have received this message by mistake, please contact the sender immediately. All emails sent to or from the Nadex corporate email system may be retained, monitored and/or reviewed by Nadex personnel. Nadex is located at 200 West Jackson Boulevard, Suite 1400, Chicago, IL 60606. Nadex is subject to U.S. regulatory oversight by the CFTC. Futures, options and swaps trading involves risk and may not be appropriate for all investors. The contents herein are not a solicitation, recommendation or offer to buy or sell any particular financial instrument listed on Nadex or elsewhere.