search

quickfix-j / quickfixj

QuickFIX/J is a full featured messaging engine for the FIX protocol. - This is the official project repository.
http://www.quickfixj.org
Other
959 stars 613 forks source link

Bump org.apache.maven:maven-plugin-api from 3.9.7 to 3.9.8 #826

Closed dependabot[bot] closed 3 months ago

dependabot[bot] commented 3 months ago

Bumps org.apache.maven:maven-plugin-api from 3.9.7 to 3.9.8.

Commits
  • 36645f6 [maven-release-plugin] prepare release maven-3.9.8
  • 105d843 [MNG-8154] Upgrade default plugin bindings
  • 37f1f02 [MNG-7758] Report dependency problems for all repository
  • 083716d [MNG-8150] Backport TransferListener improvements for Maven 3.9.x (#1576)
  • 02927b7 [MNG-8141] Aftermath, and tidy up (#1572)
  • ac5d71a Reformat, no code change
  • dd8c95c [MNG-8141][MNG-8147] Restore profile ID invariance but warn if duplicate IDs ...
  • 758e054 Revert "[MNG-8141] Model builder should report problems it finds during build...
  • 7fcd8c5 [MNG-8141] Model builder should report problems it finds during build (#1556)
  • 66266e5 [MNG-8140] Always tell why model was discarded as "invalid" (#1555)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
chrjohn commented 3 months ago

Build is failing, might need maven update.

chrjohn commented 3 months ago

No, that wasn't it.

cstamas commented 3 months ago

Problem is here:

[cstamas@angeleyes quickfixj (master *)]$ mvn -f quickfixj-class-pruner-maven-plugin eu.maveniverse.maven.plugins:toolbox:tree -Dscope=test
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------< org.quickfixj:quickfixj-class-pruner-maven-plugin >----------
[INFO] Building QuickFIX/J Class Pruner Maven Plugin 3.0.0-SNAPSHOT
[INFO]   from pom.xml
[INFO] ----------------------------[ maven-plugin ]----------------------------
[INFO] 
[INFO] --- toolbox:0.1.25:tree (default-cli) @ quickfixj-class-pruner-maven-plugin ---
[INFO] org.quickfixj:quickfixj-class-pruner-maven-plugin:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.maven:maven-plugin-api:jar:3.9.8 [provided]
[INFO] |  +- org.apache.maven:maven-model:jar:3.9.8 [provided]
[INFO] |  +- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.9.0.M3 [provided]
[INFO] |  +- org.codehaus.plexus:plexus-utils:jar:4.0.1 [compile]
[INFO] |  \- org.codehaus.plexus:plexus-classworlds:jar:2.8.0 [provided]
[INFO] +- org.apache.maven:maven-core:jar:3.9.6 [provided]
[INFO] |  +- org.apache.maven:maven-settings:jar:3.9.6 [provided]
[INFO] |  +- org.apache.maven:maven-settings-builder:jar:3.9.6 [provided]
[INFO] |  |  \- org.codehaus.plexus:plexus-sec-dispatcher:jar:2.0 [provided]
[INFO] |  |     \- org.codehaus.plexus:plexus-cipher:jar:2.0 [provided]
[INFO] |  +- org.apache.maven:maven-builder-support:jar:3.9.6 [provided]
[INFO] |  +- org.apache.maven:maven-repository-metadata:jar:3.9.6 [provided]
[INFO] |  +- org.apache.maven:maven-model-builder:jar:3.9.6 [provided]
[INFO] |  +- org.apache.maven:maven-resolver-provider:jar:3.9.6 [provided]
[INFO] |  +- org.apache.maven.resolver:maven-resolver-impl:jar:1.9.18 [provided]
[INFO] |  |  \- org.apache.maven.resolver:maven-resolver-named-locks:jar:1.9.18 [provided]
[INFO] |  +- org.apache.maven.resolver:maven-resolver-api:jar:1.9.18 [provided]
[INFO] |  +- org.apache.maven.resolver:maven-resolver-spi:jar:1.9.18 [provided]
[INFO] |  +- org.apache.maven.resolver:maven-resolver-util:jar:1.9.18 [provided]
[INFO] |  +- org.apache.maven.shared:maven-shared-utils:jar:3.4.2 [compile]
[INFO] |  +- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.9.0.M2 [provided]
[INFO] |  +- com.google.inject:guice:jar:5.1.0 [provided]
[INFO] |  |  \- aopalliance:aopalliance:jar:1.0 [provided]
[INFO] |  +- com.google.guava:guava:jar:32.0.1-jre [provided]
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1 [provided]
[INFO] |  +- javax.inject:javax.inject:jar:1 [provided]
[INFO] |  +- org.codehaus.plexus:plexus-interpolation:jar:1.26 [provided]
[INFO] |  +- org.codehaus.plexus:plexus-component-annotations:jar:2.1.0 [provided]
[INFO] |  +- org.apache.commons:commons-lang3:jar:3.12.0 [provided]
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.36 [compile]
[INFO] +- org.apache.maven:maven-artifact:jar:3.9.6 [provided]
[INFO] +- org.apache.maven:maven-compat:jar:3.9.6 [provided]
[INFO] |  \- org.apache.maven.wagon:wagon-provider-api:jar:3.5.3 [compile]
[INFO] +- org.apache.maven.plugin-tools:maven-plugin-annotations:jar:3.13.1 [compile]
[INFO] +- org.apache.maven.shared:file-management:jar:3.0.0 [compile]
[INFO] |  \- org.apache.maven.shared:maven-shared-io:jar:3.0.0 [compile]
[INFO] +- org.junit.vintage:junit-vintage-engine:jar:5.10.2 [test]
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2 [test]
[INFO] |  |  +- org.opentest4j:opentest4j:jar:1.3.0 [test]
[INFO] |  |  \- org.junit.platform:junit-platform-commons:jar:1.10.2 [test]
[INFO] |  +- junit:junit:jar:4.13.2 [test]
[INFO] |  |  \- org.hamcrest:hamcrest-core:jar:1.3 [test]
[INFO] |  \- org.apiguardian:apiguardian-api:jar:1.1.2 [test]
[INFO] +- org.apache.maven.plugin-testing:maven-plugin-testing-harness:jar:3.3.0 [test]
[INFO] |  +- commons-io:commons-io:jar:2.16.1 [test]
[INFO] |  \- org.codehaus.plexus:plexus-archiver:jar:2.2 [test]
[INFO] |     +- org.codehaus.plexus:plexus-container-default:jar:1.0-alpha-9-stable-1 [test]
[INFO] |     |  \- classworlds:classworlds:jar:1.1-alpha-2 [test]
[INFO] |     \- org.codehaus.plexus:plexus-io:jar:2.0.4 [test]
[INFO] \- org.codehaus.plexus:plexus-xml:jar:4.0.4 [test]
[INFO]    \- org.apache.maven:maven-xml-impl:jar:4.0.0-alpha-9 [test]
[INFO]       +- org.apache.maven:maven-api-xml:jar:4.0.0-alpha-9 [test]
[INFO]       |  \- org.apache.maven:maven-api-meta:jar:4.0.0-alpha-9 [test]
[INFO]       \- com.fasterxml.woodstox:woodstox-core:jar:6.5.1 [test]
[INFO]          \- org.codehaus.woodstox:stax2-api:jar:4.2.1 [test]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.431 s
[INFO] Finished at: 2024-06-18T12:00:38+02:00
[INFO] ------------------------------------------------------------------------
[cstamas@angeleyes quickfixj (master *)]$

Sisu inject and plexus goes "hand in hand" and update should be made in lockstep: make sure same version of sisu-inject and sisu-plexus are on classpath.

Moreover, you are mixing maven-plugin-api 3.9.8 with rest of maven 3.9.6.

This change fixes the build:

diff --git a/pom.xml b/pom.xml
index 9a16e957..4a7849fe 100644
--- a/pom.xml
+++ b/pom.xml
@@ -76,8 +76,8 @@
                <maven.compiler.target>8</maven.compiler.target>
                <mainClass/>
                <maven.version>3.8.7</maven.version>
-               <maven-libs-version>3.9.6</maven-libs-version>
-               <maven-plugin-api-version>3.9.7</maven-plugin-api-version>
+               <maven-libs-version>3.9.8</maven-libs-version>
+               <maven-plugin-api-version>3.9.8</maven-plugin-api-version>
                <maven-resources-plugin-version>3.3.1</maven-resources-plugin-version>
                <maven-compiler-plugin-version>3.13.0</maven-compiler-plugin-version>
                <maven-jar-plugin-version>3.4.1</maven-jar-plugin-version>
chrjohn commented 3 months ago

@cstamas thank you, I already upgraded to Maven 3.9.8 in https://github.com/quickfix-j/quickfixj/pull/827 but forgot that point you mentioned. 👍