quickfixgo / quickfix

The Go FIX Protocol Library :rocket:
https://www.quickfixgo.org/
Other
741 stars 289 forks source link

sending received "fromApp" messages messes repeating groups #608

Closed mrefky closed 4 months ago

mrefky commented 9 months ago

If I resend the received fix message to the sender I get wrong message:

example code:

func (e executor) FromApp(msg quickfix.Message, sessionID quickfix.SessionID) (reject quickfix.MessageRejectError) { quickfix.SendToTarget(msg,sessionID) }

mrefky commented 9 months ago

Example from the logs: Original send message: 2023/12/31 20:19:41.609553 8=FIX.4.49=21635=D34=2347=UTF-852=20231231-20:19:4149=0100150=01001a56=CASE44=1211=139761=1010040021=1386=1336=NOPL55=EGMFC001MM1954=160=20231231-20:19:4138=140=259=0453=1448=4501447=D452=28354=6355=Public10=130

Resent

2023/12/31 20:19:41.610119 8=FIX.4.49=22035=D34=249=CASE50=01001a52=20231231-20:19:41.60956=01001347=UTF-81=1010040011=1397621=138=140=244=1254=155=EGMFC001MM1959=060=20231231-20:19:41336=NOPL354=6355=Public386=1447=D448=4501452=28453=110=074

varunbpatil commented 9 months ago

See also https://github.com/quickfixgo/quickfix/issues/568

ackleymi commented 5 months ago

@mrefky I believe this is resolved in https://github.com/quickfixgo/quickfix/releases/tag/v0.9.1 please re-open issue if that is not the case.

mrefky commented 5 months ago

Same thing using github.com/quickfixgo/quickfix v0.9.2

Field NoTradingSessions [386] must preceed Field TradingSessionID [336]

mrefky commented 5 months ago

I dont know how to re-open this issue, please reopen and thanks for your note.