quickfixgo / quickfix

The Go FIX Protocol Library :rocket:

https://www.quickfixgo.org/

Other

723 stars 282 forks source link

Group field whose elements do not have the same fields are incorrectly parsed #623

Closed albertsundjaja closed 2 months ago

albertsundjaja commented 3 months ago

The edge case is described in the unit test added in this PR

When a group field contains more than one element and one of the elements has less params (because they are optional), it will be parsed incorrectly due to the change added in #368

e.g.

453=2448=PARTYID452=3523=SUBID448=PARTYID2452=3

in the example, the last element does not have 523 defined

this means that a fix for #365 / #366 is still required

albertsundjaja commented 3 months ago

622 is the same issue as this

dbergamin commented 3 months ago

Thanks @albertsundjaja, confirming that this would solve my issue