quickfixgo / quickfix

The Go FIX Protocol Library :rocket:
https://www.quickfixgo.org/
Other
723 stars 282 forks source link

Bug: For Logon/Logout/Resend/SequenceReset messages we should wait until sent #628

Closed AlexandrosKyriakakis closed 2 months ago

AlexandrosKyriakakis commented 2 months ago

Issue

When log on request was queued because cannot be send due to connection not ready, Then it goes through the main session loop which leads to SendAppMessages

But, since session is not logged on yet because the message queued is the log on message, we drop the toSend queued messages so we lose the log on message itself.

Proposed solution

For important messages like Logon/Logout/Resend/SequenceReset we block until sent.