Session doesn't reset if service overslept

quickfixgo / quickfix

The Go FIX Protocol Library :rocket:

https://www.quickfixgo.org/

Other

735 stars 288 forks source link

Session doesn't reset if service overslept #652

Closed filinvadim closed 1 month ago

filinvadim commented 2 months ago

With such config:

ReconnectInterval=300
StartTime=21:05:00
EndTime=21:00:00

Expected behavior - session reset. But because service was completely frozen for 5 minutes it missed "not in session" state and hasn't reset session. Possible solution - create goroutine with independent ticker for that.

filinvadim commented 2 months ago

For some reason runtime never reached this line of code: https://github.com/quickfixgo/quickfix/blob/e3a299401c851061d3317fb228c348d2623514bd/session.go#L840

ackleymi commented 2 months ago

@filinvadim I will look at this and get back this week