search

quickhac / qhac-ios

Native iOS app to allow checking of grades, based on the QuickHAC Chrome extension.
0 stars 0 forks source link

Fix GPA calculation #12

Closed tristanseifert closed 10 years ago

tristanseifert commented 10 years ago

GPA calculation results seem to be off by a rather large amount in some cases, and don't coincide exactly with what qHAC Chrome states.

tristanseifert commented 10 years ago

GPA on a 4.0 scale should include ALL courses, regardless of their excludedFromGPA property. Settings should be revised to indicate that courses are only excluded from the weighted GPA.

In addition, weighted GPA calculation should be abstracted into the SQUDistrict subclasses, rather than having one 'hack' of a method in SQUGradeManager to attempt to handle it for multiple different districts.

tristanseifert commented 10 years ago

This is still not entirely fixed; see this discussion.

It seems as if the best way of doing the calculation is finding some kind of formula to do it. Perhaps a linear regression over some example data.

tristanseifert commented 10 years ago

As of right now, both unweighted and weighted GPA yield results that coincide with what a manual calculation according to the course catalogue's specifics ends up with. I'm closing this until I hear otherwise.