search

quickjs-ng / quickjs

QuickJS, the Next Generation: a mighty JavaScript engine
https://quickjs-ng.github.io/quickjs/
MIT License
967 stars 79 forks source link

Merge JS_ToBigInt64Free into JS_ToInt64Free #415

Closed saghul closed 2 months ago

saghul commented 4 months ago

Looks like there is opportunity to simplify some things now:

JS_ToInt64Ext might be unnecessary now? Possibly also JS_ToBigInt64 even? Or should JS_ToBigInt64Free give an error if the value is not a BigInt?

saghul commented 4 months ago

Or should JS_ToBigInt64Free give an error if the value is not a BigInt?

Looking at the test failures it seems like this is indeed the case... Maybe this is not worth doing at all.