search

quickjs-ng / quickjs

QuickJS, the Next Generation: a mighty JavaScript engine
MIT License
687 stars 66 forks source link

`-fwrapv` flag needed? #444

Closed andrjohns closed 3 days ago

andrjohns commented 4 days ago

The QuickJS Makefile adds the -fwrapv flag for defined-handling of integer overflows, but it's not set in QuickJS-NG.

Is that because it's not needed here or should it also be used? Just double-checking whether I need to change build flags as part of switching a codebase over to this fork

saghul commented 3 days ago

IIRC we fixed the cases that required that flag early in the fork.

andrjohns commented 3 days ago

Great, thanks!