search

quickjs-ng / quickjs

QuickJS, the Next Generation: a mighty JavaScript engine
MIT License
698 stars 66 forks source link

cutils - Compatibility for compiling under c++ #457

Closed andrjohns closed 2 days ago

andrjohns commented 3 days ago

Minor changes needed for compiling cutils.c under C++:

saghul commented 3 days ago

Is there a way to add a CI target for this? Otherwise I fear we'll break it over and over again...

andrjohns commented 3 days ago

Is there a way to add a CI target for this? Otherwise I fear we'll break it over and over again...

Yep, but there are still a bunch of changes needed for the other headers/files so I was going to hold off until the full project was compile-able

saghul commented 3 days ago

Do you reckon it would be good to land all changes in a single PR?

andrjohns commented 2 days ago

Do you reckon it would be good to land all changes in a single PR?

Yeah probably makes sense to see it all at once, and then can always split after. Will do!