search

quicklisp / quicklisp-client

Quicklisp client.
http://www.quicklisp.org/
MIT License
298 stars 74 forks source link

Fix various stylistic issues #218

Closed kilianmh closed 2 years ago

kilianmh commented 2 years ago

Most of these changes are stylistic (improvements). Exceptions are:

Inspired by lisp-critic/40ants-critic.

quicklisp commented 2 years ago

If x may be NIL or a number, (eql x 42) is perfectly fine.

On Sun, Jul 17, 2022 at 1:20 PM Kilian M. Haemmerle < @.***> wrote:

Most of these changes are stylistic (improvements). Exceptions are:

Inspired by lisp-critic https://github.com/g000001/lisp-critic/ 40ants-critic https://github.com/40ants/40ants-critic.

You can view, comment on, or merge this pull request online at:

https://github.com/quicklisp/quicklisp-client/pull/218 Commit Summary

File Changes

(7 files https://github.com/quicklisp/quicklisp-client/pull/218/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/quicklisp/quicklisp-client/pull/218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPNLP3RTCB7C3WP7AT2ILVUQ6FXANCNFSM532BZIPQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kilianmh commented 2 years ago

If x may be NIL or a number, (eql x 42) is perfectly fine.

Indeed, that is correct! Now the case when the object might be NIL is EQL again.

If there's anything else stopping you to merge this, just let me know.

PS: Will try to put this exemption-case in the lisp-critic rule-description.