search

quicklisp / quicklisp-controller

The software to build Quicklisp dists.
Other
38 stars 12 forks source link

Archive submodules #15

Closed christophejunke closed 6 years ago

christophejunke commented 6 years ago

Related to https://github.com/quicklisp/quicklisp-projects/issues/685 and https://github.com/quicklisp/quicklisp-projects/issues/728.

When making a release tarball, add a temporary submodules/ directory and create archives for all submodules, using git submodules foreach calling git archive HEAD. Concatenate the resulting archives into the main one.

I tested by running:

(make-release-tarball 
 (make-instance 'git-source
                :project-name "cl-ledger"
                :location "https://github.com/ledger/cl-ledger")
 #P"/tmp/test.tgz")

I also let ensure-what-wins-you-can run for a while to see if projects without submodules were still building.

NB. It could be the case that a submodule is another system already registered in ASDF, possibly from another version (for example, the submodule points to a previous release). I am not sure if this is a problem and what should be in done in that case.

quicklisp commented 6 years ago

This caused me a bunch of trouble, so I've reverted it for now.

christophejunke commented 6 years ago

I understand; I will try to test that more. Do you have more details about what goes wrong?

quicklisp commented 6 years ago

I'll try to gather a failure report and share.

On Wed, Feb 7, 2018 at 6:08 AM, Christophe Junke notifications@github.com wrote:

I understand; I will try to test that more. Do you have more details about what goes wrong?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/quicklisp/quicklisp-controller/pull/15#issuecomment-363735994, or mute the thread https://github.com/notifications/unsubscribe-auth/AAT2rc5c4_jCfG7fw308-bn6egas9INsks5tSYQcgaJpZM4Rvacu .