search

quicksc0p3r / simplecounter

Apache License 2.0
52 stars 11 forks source link

[Feature] Ordering counters by dragging #6

Open VasilisKos opened 9 months ago

VasilisKos commented 9 months ago

Would be great if counters could be reordered by dragging and dropping them.

P. S. How are they ordered now by default? I guess by time of creation?

quicksc0p3r commented 9 months ago

This would have to wait until Compose has good support for drag-and-drop in lazy layouts, but we can implement a reorder mode where the plus and minus buttons would be replaced with up and down arrows (how to better implement this on the database side?)

Currently, counters are ordered by their Room database ID, which usually matches order by time of creation.

VasilisKos commented 9 months ago

This would have to wait until Compose has good support for drag-and-drop in lazy layouts, but we can implement a reorder mode where the plus and minus buttons would be replaced with up and down arrows (how to better implement this on the database side?)

Currently, counters are ordered by their Room database ID, which usually matches order by time of creation.

I'm not a developer, and don't know about programming. But this dragging I'm talking about is implemented in this open source app, fully in Kotlin: https://github.com/sadellie/unitto If you install it (it's very good by the way) and try the Time Zones feature, you'll see that you can drag the clocks you add in whatever order you want. Very smoothly. Also the order of the unit groups in the settings can be set by dragging them.

quicksc0p3r commented 9 months ago

I'm not a developer, and don't know about programming.

Kotlin + Jetpack Compose is quite easy, you can learn that in your free time :)

quicksc0p3r commented 9 months ago

But this dragging I'm talking about is implemented in this open source app

I won't be taking any code from other projects.

VasilisKos commented 9 months ago

But this dragging I'm talking about is implemented in this open source app

I won't be taking any code from other projects.

It's not stealing anything mate. You just take an idea of how to make something, from someone who's sharing his ideas and code. That's the whole philosophy of open sourcing. Sharing and making progress as a community. After all, you are already taking "code" from Google! Material You is not yours! 😁

quicksc0p3r commented 9 months ago

Let's please have issue threads on topic

VasilisKos commented 9 months ago

https://github.com/aclassen/ComposeReorderable