search

quickshiftin / mysqlbkup

Lightweight MySQL backup script in BASH
GNU Lesser General Public License v3.0
157 stars 70 forks source link

Split out configuration items into separate files #11

Closed 4fd81048-Brian closed 8 years ago

4fd81048-Brian commented 8 years ago
  1. Moved environment variables into a config file.
  2. Edits are made to config files and not the script.
  3. Moved MySQL credentials into a standard my.cnf file referred to by DEFAULTS_FILE variable.
  4. MySQL Connection and Credential information is separated and secured.
  5. mysql and mysqldump commands are called with --defaults-file=$DEFAULTS_FILE
  6. Passwords no longer appear in ps output that includes full command line.
quickshiftin commented 8 years ago

Hi this looks like a great patch! I'll take a deeper look and try to get it merged in soon. I've been really busy lately so bear with me, but I will get to it ASAP.

quickshiftin commented 8 years ago

This is awesome, thank you! The only thing I'm going to add to it is a revision for the README so folks know how to use the new setup.