search

quicksilver / GoogleChrome-qsplugin

Quicksilver Google Chrome plugin
17 stars 3 forks source link

minor issues in 1.0.0 #1

Closed skurfer closed 12 years ago

skurfer commented 12 years ago

Hello. Nice to see this finally exists. Here are some minor things I ran across in testing.

Looks really good overall!

pjrobertson commented 12 years ago
ndreas commented 12 years ago

I'll take a look at this, thank you for the feedback.

ndreas commented 12 years ago

@pjrobertson, regarding the count of 1 in the catalog, are you referring to the count in the settings dialog? Because like the Safari plugin, I think it refers to the actual open web pages object, not its children, since the children are not added to the dialog.

pjrobertson commented 12 years ago

You are right, this refers to the object itself and now the object's children, I see the same for the Safari Module. Now I understand it, I guess it's fine.

On 28 April 2012 10:22, Andreas Johansson < reply@reply.github.com

wrote:

@pjrobertson, regarding the count of 1 in the catalog, are you referring to the count in the settings dialog? Because like the Safari plugin, I think it refers to the actual open web pages object, not its children, since the children are not added to the dialog.

Reply to this email directly or view it on GitHub:

https://github.com/ndreas/GoogleChrome-qsplugin/issues/1#issuecomment-5395563

ndreas commented 12 years ago

I have fixed all the points you list, except for the count of 1, in a minor release 1.0.1: https://github.com/ndreas/GoogleChrome-qsplugin/downloads

Try it out and see if it feels ok.

pjrobertson commented 12 years ago

Looks good, a few more small things:

In the resolveProxyObject method I'd make QS NSBeep(); if Chrome isn't running (for the 'current webpage' and 'current website' proxies). I think the same should be done for the safari module as well.

It'd be nice if the 'bookmarks bar' and 'bookmarks menu' objects had the chrome icon. Now that they're available in the 1st pane, it could be difficult to know what they're for. See http://d.pr/i/cnim

ndreas commented 12 years ago

@pjrobertson regarding the icon, I feel it gets a bit cluttered when using the same icon for everything, so I found a Chrome-branded folder icon: https://www.evernote.com/shard/s11/sh/7e677944-60bd-4f54-bc0e-d5e71e05ad7e/a440fdfa9a9f5da4c1a977315083b9ae.

What are your thoughts on using that instead of the Chrome icon?

pjrobertson commented 12 years ago

What are your thoughts on using that instead of the Chrome icon?

Cool, definitely!

On 29 April 2012 09:19, Andreas Johansson < reply@reply.github.com

wrote:

@pjrobertson regarding the icon, I feel it gets a bit cluttered when using the same icon for everything, so I found a Chrome-branded folder icon: https://www.evernote.com/shard/s11/sh/7e677944-60bd-4f54-bc0e-d5e71e05ad7e/a440fdfa9a9f5da4c1a977315083b9ae .

What are your thoughts on using that instead of the Chrome icon?

Reply to this email directly or view it on GitHub:

https://github.com/ndreas/GoogleChrome-qsplugin/issues/1#issuecomment-5403430

ndreas commented 12 years ago

Just uploaded 1.0.2 which adresses the icon and beeping: https://github.com/ndreas/GoogleChrome-qsplugin/downloads

pjrobertson commented 12 years ago

Really nice, I like the icons :)

I think we should definitely try and find something equivalent for Safari, and the NSBeep() is useful as well. I'll have a play today, and hopefully get it out as official before the end of the day.

On 29 April 2012 11:28, Andreas Johansson < reply@reply.github.com

wrote:

Just uploaded 1.0.2 which adresses the icon and beeping: https://github.com/ndreas/GoogleChrome-qsplugin/downloads

Reply to this email directly or view it on GitHub:

https://github.com/ndreas/GoogleChrome-qsplugin/issues/1#issuecomment-5404041

ndreas commented 12 years ago

I think all of the issues are resolved, so I'll close this thread.