add folder to bookmark name so it can be searched

[studgeek]

It would be great if you could add a bookmark's folders to the item name so someone can quickly search using them? I'm looking to replicate the tag searching I had in the Firefox awesome bar. As an example, the QuickStar extension does this well - https://chrome.google.com/webstore/detail/gfleimmfkgmjkaclmaeanlkcnhhfldje.

PS, Thank you very much for writing this plugin, without it I could not have moved to Chrome :).

[ndreas]

That's a great idea, I'll take a look at it tonight.

[studgeek]

Cool! I looked at the code and it seems straight forward from what I can tell (all the data is there when you need it), but since I haven't written a QS plugin yet I figured if you liked the idea you could add it faster than you could rework a first QS plugin attempt pull request from me :).

On a related note, Firefox also searches the URL itself when doing search. In some cases that can be very useful (e.g. you know you are looking for a github URL), but adding that to the QS item title would make the titles pretty wide/ugly. I see the URL is shown in the description when you select a bookmark, but I guess there is no way to tell QS to search that also (it only searches titles)?

Thanks, dave

On Fri Aug 24 09:45:19 2012, Andreas Johansson wrote:

That's a great idea, I'll take a look at it tonight.

— Reply to this email directly or view it on GitHub https://github.com/ndreas/GoogleChrome-qsplugin/issues/10#issuecomment-8001659.

[ndreas]

I think it's possible to have non-visible data searchable in QS, I remember seeing it somewhere in some plugin or some documentation. I'll see if I can add that too.

[studgeek]

Awesome, thanks! If you do find how to do it please share the link. I am interested in using it to possibly fix searching for "HTML Data" for the clipboard also (though it wold be better fixed by setting the title correctly).

[ndreas]

I have looked at the changes now and I ran into a small issue. I would like to keep compatibility with other URL objects in QS, and they have the name of the bookmark (if any) as the title and the description is the actual URL. If I change the description to the folder, it breaks this pattern.

However, I have a suggestion which might be OK. It's possible to assign both a name and a label for QSObjects. When a label is defined, it's displayed by default until you search for something that matches the content of the name. This means I can set the label to the actual name of the bookmark, and the name to something that includes both the name and the folder.

An example would be something like this:

Here, the bookmark is named HTML 4.01 Reference as you can see in the dropdown list, and its folder is called Data, but with the label set to <bookmark name> in <bookmark folder>, the hit in the first pane will match HTML 4.01 Reference in Data.

I think this matches what you're looking for while still keeping compatibility with other URLs in QS. What do you think?

[studgeek]

Looks like a very cool compromise to me :).

PS, I can't seem to see the image in github, but could see it in my email.

PS2, What QS interface are you using?

[ndreas]

I'll build a new version and notify the QS devs as soon as I can so the changes come to you automatically.

The image is fixed I think, some hassle with Evernote I guess.

The QS interface is called Nostromo.

[studgeek]

Great, thank you very much!

On Fri Aug 24 12:46:19 2012, Andreas Johansson wrote:

I'll build a new version and notify the QS devs as soon as I can so the changes come to you automatically.

The image is fixed I think, some hassle with Evernote I guess.

The QS interface is called Nostromo.

— Reply to this email directly or view it on GitHub https://github.com/ndreas/GoogleChrome-qsplugin/issues/10#issuecomment-8007979.

[studgeek]

PS, Thanks for the iTerm2 plugin also - very handy!

On Fri Aug 24 14:14:29 2012, David Rees wrote:

Great, thank you very much!

On Fri Aug 24 12:46:19 2012, Andreas Johansson wrote:

I'll build a new version and notify the QS devs as soon as I can so the changes come to you automatically.

The image is fixed I think, some hassle with Evernote I guess.

The QS interface is called Nostromo.

— Reply to this email directly or view it on GitHub https://github.com/ndreas/GoogleChrome-qsplugin/issues/10#issuecomment-8007979.

[studgeek]

Did you see this patch to the QS core to add URL to searching? It seems to parallel my thought above about searching the URL also (like Firefox/Chrome does). Is there additional work needed on the Chrome plugin side to take advantage of this and would you like me to create a separate issue for it? pjrobertson/Quicksilver@b250648ee99e7c7b6a108231f6b28d79d4e6c941 which was rolled into quicksilver/Quicksilver@82068c82c21bca06a4ff2ed8ae682139d85f07fa as part of issue quicksilver/Quicksilver#1029

[ndreas]

Good thing you found that. My solution for adding the folder broke the functionality for searching for URL:s since that uses the label as well. I'll have to fix that. Back to the drawing board :)

As a separate notice, no change would have been needed to use this functionality in the plugin, since all URL objects are created using URLObjectWithURL: which calls initWithURL: and thus uses the functionality in the commits you list.

[studgeek]

Bummer, was looking forward to trying it out. I guess QS just searches name and label?

For URL search, I was just coming back to let you know that the search in URL was working in B70/3933 :).

In terms of that commit, I just came across it trying to figure out what was in B70 since there are no release notes out for it yet. I just found this thread: https://groups.google.com/d/topic/quicksilver---development/wW3WDJG3r_4/discussion

d

On 8/25/12 10:32 AM, Andreas Johansson wrote:

Good thing you found that. My solution for adding the folder broke the functionality for searching for URL:s since that uses the label as well. I'll have to fix that. Back to the drawing board :)

As a separate notice, no change would have been needed to use this functionality in the plugin, since all URL objects are created using |URLObjectWithURL:| which calls |initWithURL:| and thus uses the functionality in the commits you list.

— Reply to this email directly or view it on GitHub https://github.com/ndreas/GoogleChrome-qsplugin/issues/10#issuecomment-8023792.

[ndreas]

I came up with the compromise you see in d8ce14a, the name format is now <url> - <bookmark name> in <bookmark folder>. This way, people who expect the URL object to behave the same everywhere will still be able to match and see the URL, and you as a power user can search for the bookmark name and folder combined. The downside is that you probably won't be able to see neither the name nor the folder since QS truncates the text.

I have uploaded version 1.1.3 with these changes here: https://github.com/ndreas/GoogleChrome-qsplugin/downloads

If you want to, you can download and try it out before I tell the QS devs to release it properly.

[studgeek]

Cool, it's working (Thanks!). But I wonder if its going to confuse people that they can't see what their text is matching. That isn't just from your change, but also the core change of searching the URL also.

Actually, I'm wondering about the B70 addition of URL to search because its gotten harder to narrow down to just the right things when I search. There are so many matches amongst the URLs that its gotten harder to quickly pick out files, apps and other objects. I can definitely use what you have done, but I thought I would share because the B70 change may confuse a bunch of people when it lands

I wish I could not have them in the global catalog but still access them through their catalog object. I created an issue for it - quicksilver/Quicksilver#1066

As a side note I sure would like a wider QS Interface, I've asked the Nostromo developer if that is possible - skurfer/Nostromo#3.

Oh as long as I am chatting, out of interest why can't the folder go in the label? What does that break?

PS, Thanks for your time on this. Sorry it didn't turn out to be as quick a tweak as you had expected.

[ndreas]

Oh as long as I am chatting, out of interest why can't the folder go in the label? What does that break?

It "breaks" compatibility with for example the Safari plugin. Bookmarks there are just created with the name as the label, and I want the experience to be uniform. The appearance of the bookmarks (due to the truncation) will be the same now.

Since you seem content with the result, I'll close the issue and tell the devs I have a new version.

[studgeek]

Yes, more than content - thank you very much!

On Sun Aug 26 03:34:25 2012, Andreas Johansson wrote:

Oh as long as I am chatting, out of interest why can't the folder
go in the label? What does that break?

It "breaks" compatibility with for example the Safari plugin. Bookmarks there are just created with the name as the label, and I want the experience to be uniform. The appearance of the bookmarks (due to the truncation) will be the same now.

Since you seem content with the result, I'll close the issue and tell the devs I have a new version.

— Reply to this email directly or view it on GitHub https://github.com/ndreas/GoogleChrome-qsplugin/issues/10#issuecomment-8030985.

[studgeek]

Sorry if this is supposed to be obvious, but how did you get Nostromo to show both the label and name in your interface? I would love to have that.

I only see the label in both the title and the menu. And my menu isn't skinned. Here is a pic: