New web search type

[skurfer]

Just FYI, you'll probably want to make some small changes to the "Current Website (Chrome)" proxy object. We've added a dedicated type for search objects. See quicksilver/Quicksilver#1082

It's backward compatible for plain old web search objects, but it doesn't seem to work for the proxies in the Safari and Chrome plug-ins. (I didn't catch that before it got merged, sorry.)

All you need to do is change the type for the proxy to "qs.url.search" and set the minimum version of Quicksilver to 3936. Basically, the same thing you see in this commit.

This was done to avoid constantly checking URLs to see if they were web searches or not, and it also allows for cool things, like including the "Current Website" proxies in the third pane when using "Find With…". Well, once quicksilver/Quicksilver#1162 is merged anyway. :-)

Let me know if you have any questions.

[ndreas]

I assume this sort of breaks backwards compatibility in the plugin. Just to make sure, I'll create a separate branch that won't include this change in case I add features to the plugin that people using QS less than 3936 want to use.

I'll take a look at this as soon as I can.

[skurfer]

I assume this sort of breaks backwards compatibility in the plugin.

Yes, but I'm glad you brought that up because it gave me an idea. Instead of replacing the old type with the new, just insert the new type at the top of the list and leave the requirements out.

I just tested this with the Safari plug-in and it works with the current releases of Quicksilver and the Web Search plug-in as well as the unreleased code with the new Search URL type.

So, just do that. :-)

[ndreas]

@skurfer, the type is added, as you can see. Let me know when you release quicksilver/Quicksilver#1162 and I'll build a new version.

[skurfer]

It's a backward compatible change, so no need to wait if you want to get it out of the way. Don't forget to bump the version, though. :-)