search

quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.73k stars 285 forks source link

System hotkey commands stops working after some time #165

Closed lmartins closed 12 years ago

lmartins commented 13 years ago

I have this module installed so i can have triggers to activate expose. Just after installing the plug-in all works well but after a while the triggers will go unrecognized and the actions are no where to be found.

pjrobertson commented 13 years ago

Can you tell me your exact steps to reproduce this so I can try and copy what you're doing

lmartins commented 13 years ago

Im afraid i cant point an exact direction to reproduce it. I havent yet been able to reproduce it in a consistent manner. All i know is that happens a few times everyday. After a while the actions disappear from quicksilver actions and the corresponding triggers stop working also.

pjrobertson commented 13 years ago

What are the actions you are using, and what are the triggers? I will set the up and use them to see if I get the same problem.

What version of QS, and what OS?

Are there any error messages in the log?

On 2 April 2011 09:01, lmartins < reply@reply.github.com>wrote:

Im afraid i cant point an exact direction to reproduce it. I havent yet been able to reproduce it in a consistent manner. All i know is that happens a few times everyday. After a while the actions disappear from quicksilver actions and the corresponding triggers stop working also.

Reply to this email directly or view it on GitHub: https://github.com/quicksilver/Quicksilver/issues/165#comment_947298

lmartins commented 13 years ago

Im currently not on the same system where this happens, so if that's ok with you tomorrow or monday i will check on that system if theres anything on the log. Thank you so much for your support.

pjrobertson commented 13 years ago

Sounds good. Enjoy your weekend.

On 2 April 2011 09:33, lmartins < reply@reply.github.com>wrote:

Im currently not on the same system where this happens, so if that's ok with you tomorrow or monday i will check on that system if theres anything on the log. Thank you so much for your support.

Reply to this email directly or view it on GitHub: https://github.com/quicksilver/Quicksilver/issues/165#comment_947478

lmartins commented 13 years ago

Hello again, im on the latest public version of Quicksilver (Beta58) and OSX 10.6.7

I have some messages in the log, the following appears many times during the day: When i opened this i was pretty sure it was related to some sort of interaction between Textexpander and Quicksilver. Not anymore. Since then i've been able to run both without issues but after a while clipboard just stops collecting data.

To complete my initial comment, after those command go nowhere to be found, the only way to make them available again is to uninstall and reinstall the system hotkeys plugin.

Not sure it is related to this but i have the following many times in my console:

11/04/02 09:22:00 Quicksilver[56579] HIToolbox: ignoring exception '*\ -[NSCFArray objectAtIndex:]: index (9) beyond bounds (9)' that raised inside Carbon event dispatch ( 0 CoreFoundation 0x90e686ba __raiseError + 410 1 libobjc.A.dylib 0x969d1509 objc_exception_throw + 56 2 CoreFoundation 0x90e683e8 +[NSException raise:format:arguments:] + 136 3 CoreFoundation 0x90e6835a +[NSException raise:format:] + 58 4 Foundation 0x90696200 _NSArrayRaiseBoundException + 121 5 Foundation 0x905e9e12 -[NSCFArray objectAtIndex:] + 63 6 Clipboard Module 0x007f30dd -[QSPasteboardController tableView:willDisplayCell:forTableColumn:row:] + 104 7 AppKit 0x977086ec -[NSTableView _delegateWillDisplayCell:forColumn:row:] + 62 8 AppKit 0x976857ed -[NSTableView preparedCellAtColumn:row:] + 1362 9 AppKit 0x97684bfc -[NSTableView _dirtyVisibleCellsForKeyStateChange] + 558 10 Foundation 0x905fc3bf _nsnote_callback + 176 11 CoreFoundation 0x90def793 CFXNotificationPost + 947 12 CoreFoundation 0x90def19a _CFXNotificationPostNotification + 186 13 Foundation 0x905f125c -[NSNotificationCenter postNotificationName:object:userInfo:] + 128 14 Foundation 0x905fe669 -[NSNotificationCenter postNotificationName:object:] + 56 15 AppKit 0x975b4702 -[NSWindow _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:] + 868 16 AppKit 0x975b433d -[NSWindow orderWindow:relativeTo:] + 105 17 AppKit 0x9772e8ed -[NSWindow orderFront:] + 50 18 QSEffects 0x00091a84 -[QSWindow fakeResignKey] + 100 19 CoreFoundation 0x90def793 CFXNotificationPost + 947 20 CoreFoundation 0x90def19a _CFXNotificationPostNotification + 186 21 Foundation 0x905f125c -[NSNotificationCenter postNotificationName:object:userInfo:] + 128 22 QSCore 0x000c87d7 appChanged + 215 )

pjrobertson commented 13 years ago

How does ß59 fair up?

lmartins commented 13 years ago

Still has the same issue. I have to manually update the catalog for those triggers to become available again.

On 2011/04/24, at 11:32, pjrobertson wrote:

How does ß59 fair up?

Reply to this email directly or view it on GitHub: https://github.com/quicksilver/Quicksilver/issues/165#comment_1049632

HenningJ commented 13 years ago

This error report you posted shows an error in Clipboard Module.

From what I can tell from a quick look in the code it seems to be programmer's favorite off-by-one error. I haven't ever used the clipboard module, so I feel like I'm not the right person to fix it (not knowing what to test for...). But for anybody who wants to fix it: QSPasteboardController.m:555 should probably be 

if (rowIndex>=[currentArray count]) {

(with a >= instead of just >). Also, a few lines above, in line 550, it should probably be

return [currentArray count] **- 1**;

Another off by one error (I guess).

lmartins commented 13 years ago

When i first reported this it was relating to the clipboard, but after that i've realized that other triggers also become unavailable after QS restart. The only way to have them available again is to manually update the catalog for the modules with triggers affected.

pjrobertson commented 12 years ago

@HenningJ - why should the code be as you've described in https://github.com/quicksilver/Quicksilver/issues/165#issuecomment-1050084 ??

@lmartins - do you still have issues with triggers, this was fixed in a recent update of Quicksilver. Please try ß66 and let us know if you still have the problem.

HenningJ commented 12 years ago

@HenningJ - why should the code be as you've described in https://github.com/quicksilver/Quicksilver/issues/165#issuecomment-1050084 ??

As I said, it's an off-by-one error. The indexes of currentArray go from 0 to [currentArray count] - 1. So, if rowIndex == [currentArray count], it shouldn't try to access that element of the array.

The second part of that comment was wrong.

pjrobertson commented 12 years ago

Aaah I see your point now. Wikipedia helps as always :)

Do you mean by 'the second part of that comment was wrong' - this is wrong:

return [currentArray count] **- 1**;

I'll change the 1st part soon, but I guess that has nothing to do with the original bug reported here.

HenningJ commented 12 years ago

Do you mean by 'the second part of that comment was wrong' - this is wrong:

return [currentArray count] - 1;

Yeah, that's wrong. That should stay as it is:

return [currentArray count];

But you're right, all of this is not really related to the original bug report.