Update plugin updater to use blocks and better background thread management

pjrobertson commented 2 years ago

Fixes a crash where some NSView updates were done on the background thread
Removes a lot of the NSNotification calling
Reduces/removes some obsolete code

The code changes look pretty big and scary, but ultimately all I did was:

Switched to using the new async NSURLSession instead of the synchronous NSURLConnection to make HTTP requests. This in turn meant that I had to pass completionHandler blocks around to know what to do once the request had completed.

The plugin code is really messy/complicated. I tried to tidy it up and remove calls to delegates etc. - blocks are much cleaner

pjrobertson commented 2 years ago

Fixes #2668

skurfer commented 2 years ago

Should this be in 2.0.0 since it causes crashes pretty consistently?

pjrobertson commented 2 years ago

Yes and no. I'd say it's fairly high priority, but I don't want it to delay 2.0.0. I'm almost thinking 2.1.0 would come out a few just a few weeks after 2.0.0. We'll put 2.0 out there, wait for some feedback for 1-2 weeks, make any changes then release 2.1.0

skurfer commented 2 years ago

lgtm, and I used a test build that included these changes to grab my updated Clipboard plug-in.

quicksilver / Quicksilver

Update plugin updater to use blocks and better background thread management #2671