quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.73k stars 285 forks source link

Fix Quicksilver icon for more sizes #2685

Closed pjrobertson closed 2 years ago

pjrobertson commented 2 years ago

Some icon sizes are missing in the newest QS icon, created by vadimrob.


From @lgarron:

Would it make sense to add more resolutions to the .icns files?

In https://github.com/quicksilver/Quicksilver/pull/2544 I put a lot of care into the dimensions to match Apple's guidelines/icons, and also to make sure that the horizontal short line at the bottom remains visible in Finder at 1x monitor resolution (right side of screenshot).

Screen Shot 2022-03-16 at 17 41 39

Originally posted by @lgarron in https://github.com/quicksilver/Quicksilver/issues/2595#issuecomment-1069784894

Original .afdesign files are available in that post as well for editing

@lgarron, would you be able to update the icons?

lgarron commented 2 years ago

Okay, here's a go that tries to match @vadimrob's design and dimensions. I'll make a PR for it.

icon_16x16 icon_32x32 icon_32x32@2x icon_128x128 icon_256x256 icon_256x256@2x icon_512x512@2x

lgarron commented 2 years ago

(Splitting out into a separate comment for linking.)

If we want a bigger purple surface with a "modern" feel, I'd still be more partial to preserving the traditional Quicksilver style of using a purple inset, also matching current icons for apps like Safari:

icon_512x512@2x

icon_512x512@2x

Screen Shot 2022-03-25 at 05 38 46Screen Shot 2022-03-26 at 01 33 49

But it seems that ship has sailed for now.

pjrobertson commented 2 years ago

Fixed by #2686