search

quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.73k stars 285 forks source link

Activation key with space appears as '1' in v2.0 #2692

Closed debugDS closed 2 years ago

debugDS commented 2 years ago

Congratulation for the 2.0 release 👏

There is still a problem with the space key as a shortcut. See #2687, #2682, #2662 for more details. See #2662 for the solution.

By the way @pjrobertson you corrected kVK_Return and kVK_Escape but this involves kVK_Space.

Cheers!

pjrobertson commented 2 years ago

Thanks @debugDS for the follow-up. I'm still unable to reproduce this. Can you please:

  1. Post a screenshot of the Quicksilver 'command' preference pane that shows the issue
  2. Let me know what keyboard layout you are using (System Preferences > Keyboard > Input Sources)

I still can't reproduce, but can confirm this appears to be an issue. Your fix solves the problem (like I did in other commits) but I've noticed that the real cause of the problem is a clash between the unicode and keycode values for a key. That's where we're going wrong I think: Screenshot 2022-03-29 at 08 37 26

pjrobertson commented 2 years ago

OK, I found the real (underlying) problem - we were mixing unicodes with keycodes in the unmappedKeys struct. I've fixed this now, so these keys should now be working properly.

Thanks for all your help debugDS!

debugDS commented 2 years ago

That was fast ;-) Tx