search

quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.73k stars 285 forks source link

Fix for #2533 #2706

Closed dhoepfl closed 2 years ago

dhoepfl commented 2 years ago

Replaced CGEventSourceSecondsSinceLastEventType by CGEventSourceCounterForEventType since the first seems to consider Fn up shortly after Fn down as key down event on BigSur.

Fixes #2533.

pjrobertson commented 2 years ago

This works for me. Thanks @dhoepfl for your work on debugging!

I found one edge case: setting up 'Double modifier' for caps lock. The behaviour seems strange. It works as you might expect, but if I press capslock, wait 1-2s then re-press, it still registers in QS to open/close the interface.

Also, if I press capslock just once, then switch to another key modifier (e.g. double command) it doesn't work. It seems like if you press capslock just once, QS is 'locking' any other modifier keys until you press capslock again.

Small edge-case, which I don't think will cause a lot of problems. This fix is invariably more useful, but hopefully you can also debug that @dhoepfl !

dhoepfl commented 2 years ago

@pjrobertson I think #2717 fixes CapsLock handling. I hope switching the modifiers works now, too. I cannot test this since QS fails to show any UI for me if run from Xcode …