search

quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.73k stars 285 forks source link

Switch to Obj-c html parser (away from beautifulsoup and python) #2729

Closed pjrobertson closed 2 years ago

pjrobertson commented 2 years ago

Should fix #2728

The overheads of calling a python script and import bs4 is also a bit OTT.

I've also tried to improve link parsing in general for the modern day web (data:image images, accessibility, buttons etc.) A nice modern update to QSUURLParser.py :)

n8henrie commented 2 years ago

The overheads of calling a python script and import bs4 is also a bit OTT.

No doubt, though I bet the network request dwarfs the python in terms of time cost. At least with my rural internet!

pjrobertson commented 2 years ago

No doubt, though I bet the network request dwarfs the python in terms of time cost. At least with my rural internet!

Tell me about it :P

I've just snuck one sneaky commit in here (as I like to do, :D) which I noticed whilst debugging this - the Result window no longer 'bumps' if you try and → into something that you can't. See commit 3ea99f4

Is this a problem for @skurfer @n8henrie on macOS 11/12? When did this stop working? I almost forgot this was a thing:

https://user-images.githubusercontent.com/150431/163074776-b3fa8f54-651f-4f05-bbe6-4a7e655b91e4.mov

n8henrie commented 2 years ago

Working well for me.

pjrobertson commented 2 years ago

Thanks for the update. If you think it's good to go, please merge. The consensus in #2728 is that this also fixes the issue for them.