I hate large, complicated commits, but this here was basically necessary to completely remove QSAlertManager and all the blocks that were being thrown around. It basically undoes 9bc633fcb06657e730018e4fc2e62f16719b0157 and replaces it with a much simpler NSAlert method without blocks.
This does much more than just 'fixes #2738' - it should also fix any other deadlocks that occur because of alerts (this would also have fixed #2708 by itself.
Testing this PR, please look specifically at:
Installing new plugins
Updating plugins
Checking for updates (and going through the motions of updating QS)
Installing plugins/app updates and keeping the Task Viewer open.
I've checked through all of these, and the previous litter of bugs related to 2.0.0+ - they all seem to be working fine for me. But worth others also checking.
Fixes #2738
I hate large, complicated commits, but this here was basically necessary to completely remove QSAlertManager and all the blocks that were being thrown around. It basically undoes 9bc633fcb06657e730018e4fc2e62f16719b0157 and replaces it with a much simpler NSAlert method without blocks.
This does much more than just 'fixes #2738' - it should also fix any other deadlocks that occur because of alerts (this would also have fixed #2708 by itself.
Testing this PR, please look specifically at:
I've checked through all of these, and the previous litter of bugs related to 2.0.0+ - they all seem to be working fine for me. But worth others also checking.