[Bug]: Can't build on macOS 12.3 because `/usr/bin/python` is gone

lgarron commented 2 years ago

Before submitting your bug report, please confirm you have completed the following steps

[X] Searched the issue is not already listed in the Issue List (I've searched it)
[X] Searched in the Quicksilver Users' Group for questions relating to tech support.
[X] Downloaded the latest version of Quicksilver for your system and confirmed the issue still persists.

Bug description

The build process fails because /usr/bin/python does not exist on macOS 12.3 anymore.

https://github.com/quicksilver/Quicksilver/blob/71b02e585df7751fa456c57a4917484638a48a82/Quicksilver/Quicksilver.xcodeproj/project.pbxproj#L4525-L4526

Steps to reproduce

Update to macOS 12.3
Try to build in XCode

Expected behavior

Builds and runs successfully! :-D

MacOS Version

macOS 12

Quicksilver Version

master

Relevant Plugins

No response

Crash Logs or Spindump

No response

Screenshots

No response

Additional info

I tried to update the path to python3, which seems more sustainable than trying to get Python 2 installed these days (Homebrew doesn't even support it with default taps).

Unfortunately, that seems to stumble on syntax like: https://github.com/quicksilver/Quicksilver/blob/f017cdb008ab046da79d040a8d779ae90c682b7b/Quicksilver/Tools/python-support/markdown/__init__.py#L213

Fixing up the syntax results in import errors, and so on.

lgarron commented 2 years ago

Also, I think https://github.com/quicksilver/Quicksilver/blob/5d1ff6932fc1d3560a140a021f4abb3691852f3c/.gitmodules#L6 needs to change from git: to https: to work when you haven't set up an SSH key for GitHub.

https://github.blog/2021-09-01-improving-git-protocol-security-github/

lgarron commented 2 years ago

Never mind, I had a rebase go really bad.

quicksilver / Quicksilver