search

quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.75k stars 286 forks source link

Allow specifying the configuration for qsrelease #2869

Closed n8henrie closed 2 years ago

n8henrie commented 2 years ago

Fixes https://github.com/quicksilver/Quicksilver/issues/2868

pjrobertson commented 2 years ago

LGTM. One issue I have is that CURRENT_ARCH=$(arch) gives me i386. Apparently this is a quirk with arch(see here) - I think what we actually want is uname -m. Can you confirm and make the change if necessary?

P.S. Right now, to get around this I define CI when I run qsrelease like this:

CI="blahblahblah" ./qsrelease

n8henrie commented 2 years ago

One issue I have is that CURRENT_ARCH=$(arch) gives me i386

Interesting! https://superuser.com/a/835519/321164

Right now, to get around this I define CI when I run qsrelease like this:

😆 Sorry about that.

PR soon.

n8henrie commented 2 years ago

Converted to a draft -- added some debug stuff to see what the values are in CI (which I will remove before ready to merge).

EDIT: done, ready for merge I think

n8henrie commented 2 years ago

@pjrobertson @skurfer would you guys mind pulling and building locally to make sure the uname -m change works okay locally? Seems like it's doing the right thing in CI.

n8henrie commented 2 years ago

Closing in favor or https://github.com/quicksilver/Quicksilver/pull/2871, which contains this and a bit more.

pjrobertson commented 2 years ago

OK. I was just about to review this :)